feat: improve QuickTSR logging #297
Merged
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
used to be [object Object]
it can be enabled with `reportAllCommands: true` and `debug: true` respectively
Julusian
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Small improvements in QuickTSR (no production code changes for consumers of the actual library, so maybe it's more of a chore than a feat?)
What is the current behavior? (You can also link to an open issue here)
Device status is logged as
[object Object]. No debug and command logs when enabled for devicesWhat is the new behavior (if this is a feature change)?
Device status is stringified. Command report and debug logging work when enabled with
reportAllCommands: trueanddebug: truerespectively.Other information:
Opened towards release49, but I can change that if needed.